Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #2

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Update dependencies #2

merged 11 commits into from
Nov 10, 2023

Conversation

bernd
Copy link

@bernd bernd commented Nov 8, 2023 •
edited
Loading

  • Fix ANTLR grammar issue to allow updating to 4.13.1
  • Remove ObjectSizeCalculator to allow building with Java 17
  • Remove unused dependencies
  • Update plugin versions
  • Update dependency versions
  • Update GHA workflow

Refs Graylog2/graylog2-server#16681

bernd added 8 commits November 8, 2023 15:50
@bernd
Update antlr to 4.9.3 and fix grammar issue
9a0dcd0
@bernd
Update GHA workflow
5032e45
@bernd
Remove ObjectSizeCalculator class to fix build with Java 17
a0ebe51 
The ObjectSizeCalculator class is using reflective access which doesn't
work with Java 17 anymore.

Adjust the SiddhiMemoryUsageMetric class to always return 0 for object
size.
@bernd
Bump antlr to 4.13.1
55b9f23 
Also bump jacoco to fix build with Java 17.
@bernd
Clean up unused dependencies in modules
43c4ddb
@bernd
Update plugin versions
90b0f9b
@bernd
Update dependencies
11e71c9
@bernd
Fix tests
24e7db3
@bernd bernd requested a review from mpfz0r November 8, 2023 17:39
@mpfz0r
Copy link

mpfz0r commented Nov 9, 2023

Got a local test failure with this change

[ERROR] Tests run: 1407, Failures: 1, Errors: 0, Skipped: 27, Time elapsed: 1,765.322 s <<< FAILURE! - in TestSuite
[ERROR] incrementalStreamProcessorTest18(org.wso2.siddhi.core.aggregation.Aggregation1TestCase)  Time elapsed: 0.225 s  <<< FAILURE!
java.lang.AssertionError: In events matched
	at org.wso2.siddhi.core.aggregation.Aggregation1TestCase.incrementalStreamProcessorTest18(Aggregation1TestCase.java:904)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   Aggregation1TestCase.incrementalStreamProcessorTest18:904 In events matched
[INFO] 
[ERROR] Tests run: 1407, Failures: 1, Errors: 0, Skipped: 27

@mpfz0r
Copy link

mpfz0r commented Nov 9, 2023

Works and LGTM. Couldn't reproduce the test failure 🤷

@bernd bernd merged commit a4a8637 into graylog-repackaging Nov 10, 2023
2 checks passed
@bernd bernd deleted the update/dependencies branch November 10, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfz0r mpfz0r Awaiting requested review from mpfz0r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernd @mpfz0r